Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct oblique #327

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Correct oblique #327

merged 4 commits into from
Oct 3, 2023

Conversation

Gab-D-G
Copy link
Collaborator

@Gab-D-G Gab-D-G commented Oct 2, 2023

No description provided.

@Gab-D-G
Copy link
Collaborator Author

Gab-D-G commented Oct 2, 2023

This will likely create conflicts with #326 , but will be easily resolved.

@Gab-D-G
Copy link
Collaborator Author

Gab-D-G commented Oct 2, 2023

It would be ideal to add an automated check on whether the data is oblique before applying the correction, to prevent converting images which don't need it. Any input on this @grandjeanlab or @gdevenyi (in relation to #160)?

@gdevenyi
Copy link
Member

gdevenyi commented Oct 2, 2023

I would rather this remain manual.

I'm in favour of adding a check for oblique data and erroring out, recommending the user investigate its origin and explain the use of the deoblique option.

@Gab-D-G Gab-D-G merged commit 986cc3b into master Oct 3, 2023
1 check passed
@Gab-D-G Gab-D-G deleted the correct_oblique branch October 3, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants